Implement <?xml completion in DTD files #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
May 31, 2019
| ArrayList<DTDAttlistDecl> internalDecls = attlist.getInternalChildren(); | ||
| if (decl.isDTDAttListDecl()) { | ||
| DTDAttlistDecl attlist = (DTDAttlistDecl) decl; | ||
| ArrayList<DTDAttlistDecl> internalDecls = attlist.getInternalChildren(); |
There was a problem hiding this comment.
Change ArrayList to List
angelozerr
reviewed
May 31, 2019
| } | ||
| } else { | ||
| boolean multipleInternalAttlistDecls = false; | ||
| ArrayList<DTDDeclParameter> params = attlist.getParameters(); |
There was a problem hiding this comment.
Change ArrayList to List
yes please. The basic idea is to use interface and not implementation of collection, list. But problem comes from too DTDDeclNode#getParameters should return List (interface) and not ArrayList (implementation of List). Please change that too. |
|
Ok, I have made the changes |
| private static void addPIToXMLBuilder(DOMNode node, XMLBuilder xml) { | ||
| DOMProcessingInstruction processingInstruction = (DOMProcessingInstruction) node; | ||
| xml.startPrologOrPI(processingInstruction.getTarget()); | ||
| if (processingInstruction.hasAttributes()) { |
There was a problem hiding this comment.
A processing instruction will never have attributes, it's always text content (the case below).
|
@NikolasKomonen I have made the changes. |
fbricon
reviewed
Jun 3, 2019
| @@ -33,7 +34,7 @@ | |||
| public DTDDeclParameter unrecognized; // holds all content after parsing goes wrong in a DTD declaration (ENTITY, ATTLIST, ...). | |||
| public DTDDeclParameter declType; // represents the actual name of the decl eg: ENTITY, ATTLIST, ... | |||
|
|
|||
| ArrayList<DTDDeclParameter> parameters; | |||
| List<DTDDeclParameter> parameters; | |||
Signed-off-by: David Kwon <[email protected]>
angelozerr
added
completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Previously, the prolog in
.dtdfiles were not being parsed by theDOMParseras aDOMProcessingInstruction, like.xmlfiles were.Changing
XMLScanner.javafixed that. Now that the prolog in.dtdfiles are considered to be aDOMProcessingInstruction, prolog auto-completion now works in.dtdfiles.Since
.dtdfiles could now contain aDOMProcessingInstructionin their respectiveDOMDocument,XMLFormatter.javahad to be changed to take that into account. The "if else" structure inXMLFormatter.javawas also cleaned up.Signed-off-by: David Kwon [email protected]