-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry/event support #493
Conversation
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/Platform.java
Outdated
Show resolved
Hide resolved
@fbricon here my vscode trace: [Trace - 15:05:19] Received notification 'telemetry/event'.
Params: {
"version": "0.8.0-20190701-1255",
"os": {
"name": "Windows 10",
"version": "10.0",
"arch": "amd64"
},
"jvm": {
"name": "OpenJDK 64-Bit Server VM",
"version": "1.8.0_212-3-redhat",
"memory": {
"free": 520615944,
"total": 534773760,
"max": 1073741824
}
}
}
|
b39ac8d
to
852df7f
Compare
@fbricon I have add telemetry to track explicit action from user, that's to say:
In vscode trace, you should see :
if you format a XML file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, but please add some unit tests before we merge it.
It will hard to do that since it depends on OS where JUnit are executed (I think about JVM and OS information). Or perhaps you wish I write test just with rename, formatting, rangeFormatting, and onInitialized but by avoiding value check of OS, JVM memories? An another question, I tell me if we should give the capability to send telemetry or not. Here some ideas:
|
You can check telemetry data contain the same values as what's in Platform, and then check memory values are > 0. Yes an |
Done with https:/angelozerr/lsp4xml/pull/493/files#diff-06ace1651d73790f809dd84073bc3a86R45 |
Ok test was updated.
Done in PR redhat-developer/vscode-xml#165 |
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/XMLTelemetrySettings.java
Outdated
Show resolved
Hide resolved
33f2df3
to
024933d
Compare
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/Platform.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
/** | ||
* Returns the system property from the given key and null otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "unknown"
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/Platform.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/telemetry/TelemetryManager.java
Show resolved
Hide resolved
This PR fix #430 The OSUtils was renamed to Platform which is more generic (eclipse like name) which contains information about OS, JVM (name, version, memory). Signed-off-by: azerr <[email protected]>
Telemetry includes: * Whether the Java server or the binary server * LemMinX version information (from git) * Information on the JVM Please refer to `USAGE_DATA.md` for a full list of data collected. Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes eclipse#430 Rebase of eclipse#493 Signed-off-by: David Thompson <[email protected]>
Please refer to `USAGE_DATA.md` for a full list of data collected. Add `xml.telemetry.enable` to control if telemetry events are sent. Closes #430 Rebase of #493 Signed-off-by: David Thompson <[email protected]>
Replaced with #989 |
This PR fix #430
The OSUtils was renamed to Platform which is more generic (eclipse like
name) which contains information about OS, JVM (name, version, memory).
Signed-off-by: azerr [email protected]