Fix error range for cvc-datatype-valid-1-2-1
#542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Jul 24, 2019
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/dom/DOMElement.java
Outdated
Show resolved
Hide resolved
angelozerr
changed the title
cvc-datatype-valid-1-2-1
fbricon
requested changes
Aug 20, 2019
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/utils/DOMUtils.java
Outdated
Show resolved
Hide resolved
|
@fbricon do you think we can merge this PR? |
|
@angelozerr I trust you to review and test it |
...c/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/XMLSchemaErrorCode.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
|
@xorye Works well, just some small things to change. Should be good to merge after. |
Signed-off-by: David Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323
Xerces gives us the location of the element
<a>. This PR looks at the contents of<a>to determine the error range.If there are no non-whitespace characters in the element's contents, the error range looks like this:
Signed-off-by: David Kwon [email protected]