Entity documentation has no value for entities declared with SYSTEM OR PUBLIC #746
Conversation
|
This PR:
|
|
Right now, it seems like this PR takes care of most of the issues. But the documentation for #741's case is different from the documentation for #742 741: 742: To stay consistent, the #742's case should have I understand that this is a draft PR, so sorry if the implementation wasn't done |
Indeed it was a bug, it should be fixed.
No please give me feedback and don't hesitate to give me those kind of comments. It's draft PR because I have not written test and not commented my code. |
angelozerr
force-pushed
the
entity-system
branch
6 times, most recently
from
5435630
to
0723e3b
Compare
|
Test are now written, please review it. |
PUBLIC Fixes eclipse#741 Signed-off-by: azerr <[email protected]>
| public static MarkupContent getDocumentation(DTDEntityDecl entity, EntityOriginType type, boolean markdown) { | ||
| String systemID = entity.getSystemId(); | ||
| String publicID = entity.getPublicId(); | ||
| String targetURI = entity.getNameParameter().getTargetURI(); |
There was a problem hiding this comment.
Do we need to check if entity.getNameParameter() == null here? Although, I'm not sure if it would happen in our case
There was a problem hiding this comment.
If entity has name, entity.getNameParameter() is not null, so we don't need to check that.
|
This PR looks & works great |
Entity documentation has no value for entities declared with SYSTEM OR PUBLIC
Fixes #741
Signed-off-by: azerr [email protected]