Don't send invalid catalog notifications for paths with file scheme #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorye
changed the title
angelozerr
reviewed
Aug 5, 2020
| * @param path the path to check | ||
| * @return true if the provided path exists and false otherwise | ||
| */ | ||
| public static boolean pathExists(String path) { |
There was a problem hiding this comment.
I wonder if you could use the existing FilesUtils.getPath to avoid creating a new utility method?
There was a problem hiding this comment.
Fixed. I removed this method and now I am using Files.notExists(FilesUtils.getPath(c)); and Files.exists(FilesUtils.getPath(c));
angelozerr
reviewed
Aug 7, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/FilesUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kwon <[email protected]>
|
Thanks @xorye ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-xml#289
The reason why completion from the catalog was working even though there was an error notification was because
XMLCatalogResolverExtensionusednew URI(catalogFile).getPath()whileXMLCatalogPluginusednew URI(catalogFile).toString().I removed
isXMLCatalogFileValid()fromXMLCatalogResolverExtensionandXMLCatalogPlugin, and moved it into a utils class.Signed-off-by: David Kwon [email protected]