Display if server is a native binary in init message #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Dec 21, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/ServerInfo.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Dec 21, 2020
Comment on lines
93
to
94
| append(details, "Java", getJava()); | ||
| append(details, "Native Image", Boolean.toString(IS_NATIVE_IMAGE)); |
There was a problem hiding this comment.
if (IS_NATIVE_IMAGE) {
append(details, "Native Image", null);
} else {
append(details, "Java", getJava());
}We might also display graalvm/substratevm version instead
There was a problem hiding this comment.
I added a "VM Version" entry that will show the java.vm.version, which will show the GraalVM version when running as a native-image, or the Java version if using a JDK/JRE.
datho7561
force-pushed
the
message-when-binary
branch
2 times, most recently
from
7d80642
to
d7c20a1
Compare
Adds a 'Native Image' entry to the initialization information. If LemMinX is running as a `native-image` binary, it is set to true. Closes eclipse#949 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
message-when-binary
branch
from
d7c20a1
to
c645785
Compare
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'Native Image' entry to the initialization information.
If LemMinX is running as a
native-imagebinary, it is set to true.Closes #949
Signed-off-by: David Thompson [email protected]