Choose 'best' resource when file url is ambiguous #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Eclipse workspace it is possible that a single file corresponds to multiple workspace resources. This typically arises in 'multi-project' setups where both the parent project and its nested children are imported into the workspace. This creates all sorts of confusions and subtle bugs. The logical solution seems to be to deliberatly choose the 'most nested' resource instead of just arbitarily picking the first one found. This small does just that in LSPEclipseUtils. This indirectly fixes issues in STS such as: spring-projects/sts4#769 spring-projects/sts4#747
|
@mickaelistria What do you think about this one? I think the overall issue to avoid opening the file that is associated with a parent project (in case of multi module maven projects for example) and instead the file "in the real project" makes super sense, but I wonder it you have any suggestions for the implementation? |
|
Thanks for this good change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Eclipse workspace it is possible that a single file corresponds
to multiple workspace resources. This typically arises in 'multi-project'
setups where both the parent project and its nested children are
imported into the workspace.
This creates all sorts of confusions and subtle bugs.
The logical solution seems to be to deliberatly choose the
'most nested' resource instead of just arbitarily picking the
first one found.
This small PR does just that in LSPEclipseUtils.
This indirectly fixes issues in STS such as:
spring-projects/sts4#769
spring-projects/sts4#747
cc @BoykoAlex