Rename outcome to status #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to eclipse#125 Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Emily-Jiang
requested changes
Jun 21, 2018
README.adoc
Outdated
|
|
||
| Within CDI contexts, beans that implement `HealthCheck` and annotated with `@Health` are discovered automatically and are invoked by the framework or runtime when the outermost protocol entry point (i.e. `http://HOST:PORT/health`) receives an inbound request. | ||
| Within CDI contexts, beans that implement `HealthCheck` are discovered automatically and are invoked by the framework or runtime when the outermost protocol entry point (i.e. `http://HOST:PORT/health`) receives an inbound request. |
There was a problem hiding this comment.
The previous sentence asks to annotated with @health. You should not change this under this issue though. We can discuss this under a different issue on whether it is necessary to require @Health. I see there is no point either. However, we need to discuss this under a different issue.
There was a problem hiding this comment.
This is more a cleanup as @Health has been deprecated in the last version of the spec. I will revert this commit.
Signed-off-by: Clement Escoffier <[email protected]>
Emily-Jiang
approved these changes
Jun 22, 2018
|
This change breaks service meshes. Can we revert most of these changes? The miscellaneous cleanups are fine... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #125
This PR:
outcomewithstatusas discussed in Revisit the message body of health #125statewithstatusas discussed in Revisit the message body of health #125@Healthannotation from the main README file