Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RISC-V: update CI job #6913

Merged
merged 2 commits into from
Mar 14, 2023
Merged

RISC-V: update CI job #6913

merged 2 commits into from
Mar 14, 2023

Conversation

janvrany
Copy link
Contributor

@janvrany janvrany commented Mar 3, 2023

This PR attempts to stabilize RISC-V CI job by

  • disabling RWMutex tests which seem to hang time to time
  • explicitly set OMR_EXE_LAUNCHER to make used QEMU explicit.

Related to issue #6905

@janvrany
Copy link
Contributor Author

janvrany commented Mar 3, 2023

jenkins build riscv

1 similar comment
@janvrany
Copy link
Contributor Author

janvrany commented Mar 3, 2023

jenkins build riscv

@janvrany
Copy link
Contributor Author

janvrany commented Mar 3, 2023

FYI: @AdamBrousseau

@janvrany
Copy link
Contributor Author

janvrany commented Mar 7, 2023

jenkins build riscv

AdamBrousseau
AdamBrousseau approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lftm simply based on the PR build passing. I am not a committer though.

@jdmpapin jdmpapin mentioned this pull request Mar 9, 2023
Merged
@janvrany
Copy link
Contributor Author

jenkins build riscv

dsouzai
dsouzai approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @AdamBrousseau's approval.

@dsouzai
Copy link
Member

dsouzai commented Mar 14, 2023

mac build failure is because of #6924

@dsouzai
Copy link
Member

dsouzai commented Mar 14, 2023

jenkins build xlinux

@dsouzai
Copy link
Member

dsouzai commented Mar 14, 2023

Running non-riscv build just to validate changes don't impact non-riscv builds.

@dsouzai dsouzai self-assigned this Mar 14, 2023
@dsouzai dsouzai merged commit 6b9c970 into eclipse:master Mar 14, 2023
@janvrany janvrany mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBrousseau AdamBrousseau AdamBrousseau approved these changes

@dsouzai dsouzai dsouzai approved these changes

@youngar youngar Awaiting requested review from youngar

@charliegracie charliegracie Awaiting requested review from charliegracie

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

Assignees

@dsouzai dsouzai

Labels
build / configure ci comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janvrany @dsouzai @AdamBrousseau