x86: fix packing in arrayset evaluator #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the arrayset evaluator when packing negative integers into the high bytes of a GPR. The packing instruction sequence needs to zero-extend the value being copied. Otherwise, every other element in the packed result can be incorrect. Signed-off-by: BradleyWood <[email protected]>
|
jenkins build all |
|
@hzongaro Would you mind reviewing? |
|
Update: It seems that there is a lot of history of platform-specific portions of code generation using the platform as a prefix in commit messages, in spite of the commit guidelines. I'll withdraw my request to make a change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue in the arrayset
evaluator when packing negative integers
into the high bytes of a GPR. The packing
instruction sequence needs to zero-extend
the value being copied. Otherwise, every
other element in the packed result can
be incorrect.
Issue #6944