Don't version BNDCHK based on an IV if the loop test is backwards #7250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an increasing loop-driving IV, the loop test must impose an upper bound, e.g. while (i < n), whereas for a decreasing loop-driving IV, the loop test must impose a lower bound instead, e.g. while (i >= n). Otherwise, the predicted maximum iteration count will be wrong, which could allow a bound check to be incorrectly skipped. Loop versioner will now check to ensure that the direction of the loop test agrees with the sign of the step of the loop-driving IV.
|
@vijaysun-omr, would you mind reviewing? |
vijaysun-omr
approved these changes
Feb 8, 2024
|
jenkins build all |
|
jenkins build riscv |
|
Failures look to be infra related. The change itself looks conservative/safe to me and in common code. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an increasing loop-driving IV, the loop test must impose an upper bound, e.g.
while (i < n), whereas for a decreasing loop-driving IV, the loop test must impose a lower bound instead, e.g.while (i >= n). Otherwise, the predicted maximum iteration count will be wrong, which could allow a bound check to be incorrectly skipped.Loop versioner will now check to ensure that the direction of the loop test agrees with the sign of the step of the loop-driving IV.
Fixes eclipse-openj9/openj9#18803