-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra for mmap memory backed by temporary files #7262
Conversation
@babsingh Could you please review this portlib PR or delegate? Thanks |
@keithc-ca Can you please review this PR as well? |
a36dd9d
to
ecddbfc
Compare
@babsingh I have addressed all your suggestions from the review. |
@keithc-ca I have addressed all your comments. The PR is ready for another review. Thanks |
Thanks.
Yes, it is a drawback. Currently, we can't preserve the grouping by topic and numbering simultaneously. Preserving tracepoint numbering takes precedence to avoid customer issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, with a suggestion for making it better still.
jenkins build all |
The latest push introduces a subtle change: previously, if we failed to open our file, we attempt to use an anonymous map with this code:
As long as MAP_ANONYMOUS or MAP_ANON are defined on the system, everything is good. However if MAP_ANONYMOUS and MAP_ANON are not defined, then we try to use a mmap operation with
|
f650946
to
bc8d5af
Compare
This commit adds support for allocating memory using mmap and backing that memory by a temporary file. The goal is to reduce the amount of physical memory in use by saving the content of an infrequently used memory segment to its backing file using the madvise() system call with a hint of MADV_PAGEOUT. This feature is only available for Linux. Signed-off-by: Marius Pirvu <[email protected]>
jenkins build all |
jenkins build win |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSX PR build failed due to a known and unrelated issue: #7181.
This commit adds support for allocating memory using mmap and backing that memory by a temporary file.
The goal is to reduce the amount of physical memory in use by saving the content of an infrequently used memory segment to its backing file using the madvise() system call with a hint of MADV_PAGEOUT.
This feature is only available for Linux.