Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the coding standard #7363

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

singh264
Copy link
Contributor

@singh264 singh264 commented Jun 6, 2024

Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng [email protected]
Co-authored-by: Keith W. Campbell [email protected]
Signed-off-by: Amarpreet Singh [email protected]

@singh264
Copy link
Contributor Author

singh264 commented Jun 6, 2024

@tajila @JasonFengJ9 @keithc-ca how can I request your review?

doc/CodingStandard.md Outdated Show resolved Hide resolved
@singh264
Copy link
Contributor Author

singh264 commented Jun 6, 2024

@tajila @JasonFengJ9 @keithc-ca how can I re-request your review?

@singh264 singh264 closed this Jun 6, 2024
@singh264 singh264 reopened this Jun 6, 2024
Copy link
Member

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarity comes from the similarity to the mathematical notation $min \le value \le max$ (except that $value$ must be repeated).

@singh264
Copy link
Contributor Author

singh264 commented Jun 6, 2024

@tajila @JasonFengJ9 @keithc-ca @babsingh how can I re-request your review?

doc/CodingStandard.md Outdated Show resolved Hide resolved
doc/CodingStandard.md Outdated Show resolved Hide resolved
doc/CodingStandard.md Outdated Show resolved Hide resolved
@singh264
Copy link
Contributor Author

singh264 commented Jun 6, 2024

@tajila @JasonFengJ9 @keithc-ca @babsingh how can I re-request your review?

doc/CodingStandard.md Outdated Show resolved Hide resolved
Issue: eclipse-openj9/openj9#19261
Co-authored-by: Jason Feng <[email protected]>
Co-authored-by: Keith W. Campbell <[email protected]>
Co-authored-by: Babneet Singh <[email protected]>
Signed-off-by: Amarpreet Singh <[email protected]>
@singh264
Copy link
Contributor Author

singh264 commented Jun 7, 2024

@tajila @JasonFengJ9 @keithc-ca @babsingh how can I re-request your review?

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more PR builds are needed since only the coding standards are updated.

@babsingh babsingh merged commit 361c9df into eclipse:master Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants