Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable vector API #7374

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

BradleyWood
Copy link
Member

No description provided.

@BradleyWood
Copy link
Member Author

jenkins build all

@BradleyWood BradleyWood requested review from 0xdaryl and removed request for dsouzai June 12, 2024 15:53
@@ -789,6 +789,8 @@ TR::OptionTable OMR::Options::_jitOptions[] = {
SET_OPTION_BIT(TR_EnableJitSamplingUpgradesDuringHWProfiling), "F", NOT_IN_SUBSET},
{"enableUpgradingAllColdCompilations", "O\ttry to upgrade to warm all cold compilations", SET_OPTION_BIT(TR_EnableUpgradingAllColdCompilations), "F"},
{"enableValueTracing", "O\tenable runtime value tracing (experimental)", SET_OPTION_BIT(TR_EnableValueTracing), "F"},
{"enableVectorAPIExpansion", "M\tForce enable expansion of Vector API", SET_OPTION_BIT(TR_EnableVectorAPIExpansion), "F"},
Copy link
Contributor

@gita-omr gita-omr Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that disableVectorAPIExpansion prevails.

Copy link
Contributor

@gita-omr gita-omr Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being picky but I think it's better to remove "Force" from it. I think it might cause confusion with enforceVectorAPIExpansion option.

@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 12, 2024

What's the difference between the "enforce" vector API expansion option and "enable" vector API expansion option?

@gita-omr
Copy link
Contributor

gita-omr commented Jun 12, 2024

What's the difference between the "enforce" vector API expansion option and "enable" vector API expansion option?

enforceVectorAPIExpansion works when VectorAPIExpansion is enabled and enables some temporary work-arounds to make expansion happen more often. enableVectorAPIExpansion will enable expansion on platforms it might be disabled on by default.

Both are temporary options. But I would say enableVectorAPIExpansion is more likely to be removed in the future, since all platforms will have it on by default.

@0xdaryl 0xdaryl merged commit c8ff027 into eclipse:master Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants