Fix trace format for MemorySubSpace #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitripivkine please, review |
Various trace points use %llx (long long - 64bit) while it should use %zx or %p (size_t - 32/64 bit) format to print MemorySubSpace addresses and allocation result (address in heap), what would work both for 32bit and 64bit VMs. Settling with %p, since it's already predominant. Signed-off-by: Aleksandar Micic <[email protected]>
amicic
force-pushed
the
fix_trace_format_MemeorySubSpace
branch
from
0b6c452
to
de2d500
Compare
dmitripivkine
approved these changes
Jun 17, 2024
|
@babsingh Would you please help with merging? |
|
jenkins build all |
babsingh
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various trace points use %llx (long long - 64bit) while it should use
%zx or %p (size_t - 32/64 bit) format to print MemorySubSpace addresses
and allocation result (address in heap), what would work both for 32bit
and 64bit VMs. Settling with %p, since it's already predominant.