Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi compliant jars #62

Merged
merged 1 commit into from
Dec 20, 2019
Merged

OSGi compliant jars #62

merged 1 commit into from
Dec 20, 2019

Conversation

tomvdbussche
Copy link

Fixes #59

@gitpod-io
Copy link

gitpod-io bot commented Dec 17, 2019 •
edited
Loading

@tomvdbussche
Copy link
Author

Based on https:/eclipse/lsp4j/blob/master/gradle/manifest-gen.gradle with minor tweaks to make use of guava provided by orbit. Tested locally and it seems to work correctly.

@tomvdbussche
Copy link
Author

Also I didn't know if I needed to change the license header since I basically duplicated it from the lsp4j project.

OSGi compliant jars
bbd3bfb 
Signed-off-by: Tom Vandenbussche <[email protected]>
@spoenemann spoenemann merged commit 439d5a3 into eclipse-sprotty:master Dec 20, 2019
@spoenemann
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSGi compliant jars
2 participants
@tomvdbussche @spoenemann