Refactoring(2): Temp data are kept in memory after renaming

[sailingKieler]

The temporary resource sets created and populated during rename or move refactorings are kept in memory for too long, potentially for whole life of the application. That may happen if the language injectors are initialized in a ModalContextThread, which transitively holds the refactoring data, because Guice 3.0 injectors hold the creatingThread objects for their entire lifes, see

IMO the observed scenario is hardly avoidable without changing the implementation ModalContext, modifying Guice, or significantly changing the initialization of the involved injectors. However, at least the ChangeSerializer instances with their temporary data should be disposed once the text changes have been prepared.

[cdietrich]

@sailingKieler can you please describe what is left open and what is already solved by your pr?

[sailingKieler]

The problem described in the title

Temp data are kept in memory after renaming

is fixed, so the issue can be closed.
An open question is whether that aspect could be improved:

because Guice 3.0 injectors hold the creatingThread objects for their entire lifes

I saw that with Guice 4.1 that part changed significantly but I don't know wether it would be desirable or even possible to update Guice. Maybe a change of ModalContextThread should be proposed that adds dropping of the operation data once the thread is terminated.

[cdietrich]

that would be eclipse/xtext-core#393