Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tanstack query v5 #459

Open
andi0b opened this issue Oct 19, 2023 · 8 comments
Open

Support tanstack query v5 #459

andi0b opened this issue Oct 19, 2023 · 8 comments

Comments

@andi0b
Copy link

andi0b commented Oct 19, 2023

See this guide: https://tanstack.com/query/latest/docs/react/guides/migrating-to-v5

@ThibautMarechal
Copy link

ThibautMarechal commented Oct 30, 2023

I'm taking a look at this

@nhaustov
Copy link

v5 also has suspense queries which remove a lot of boilerplate dealing with pending and error states (https://tanstack.com/query/v5/docs/react/reference/useSuspenseQuery). It would be good to support them in zodios, possibly with another boolean flag (suspense: true).

@ThibautMarechal
Copy link

@nhaustov Adding a boolean to control if it will suspense or not, will goes against the rules of hooks.

I can try to work on it @ecyrbe ?
It may require some refactoring since lot of the code would be duplicated with the useSuspenceQuery, useQuery, useImmutableSuspenseQuery, useImmutableSuspenseQuery.

Should I make it in the same pull-request ?

@andi0b
Copy link
Author

andi0b commented Nov 20, 2023

I think it would be great to just get out a release with tanstack query v5 and no support of suspense query. and add the suspense feature in a later pull request.

Edit: this would allow current users to just upgrade to query v5. Additional features can be added in a later step.

@ArFnds
Copy link

ArFnds commented Dec 13, 2023

Hi,
The merge of the PR #464 is planned ?

@andi0b
Copy link
Author

andi0b commented Dec 13, 2023

Looks like the project is dead. I think it should be removed as a suggestion from the Zodios docs.

@ThibautMarechal
Copy link

@ecyrbe was busy on another project and is expected to get back early 2024 (readed from twitter)

@ismail-codar
Copy link

It's time to move from a single person project to many people. I hope @ecyrbe sees this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants