-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: adopt bzlmod #3116
Merged
Merged
bazel: adopt bzlmod #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Will this require any changes to our renovate.json
?
As far as I can tell, renovate already natively supports bzlmod. Although I need to (and will) test if the |
malt3
force-pushed
the
bazel/adopt-bzlmod
branch
2 times, most recently
from
May 22, 2024 09:42
52e8722
to
ecbfd6e
Compare
1 task
burgerdev
reviewed
May 22, 2024
3rdparty/bazel/com_github_google_go_tpm_tools/com_github_google_go_tpm_tools.need
Outdated
Show resolved
Hide resolved
This change enables bzlmod without migrating any dependencies. Instead, WORKSPACE dependencies can be migrated one by one.
The mkosi_image rule uses a lot of memory. In order to allow higher levels of concurrency, such as `bazel build --jobs 128`, we need to more accurately model the amount of CPU and memory required.
malt3
force-pushed
the
bazel/adopt-bzlmod
branch
4 times, most recently
from
May 22, 2024 13:51
e0412fb
to
5f79bc7
Compare
burgerdev
approved these changes
May 22, 2024
While it does have some quirks before Bazel 7.2, it is still vital for security.
Coverage report
|
daniel-weisse
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Bzlmod is the new dependency management system of Bazel. It works in a similar way as
go mod
.Proposed change(s)
Additional info
Checklist