Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: matching f-a-ecomms returns exactly #185

Merged
merged 3 commits into from
Mar 18, 2024
Merged

fix: matching f-a-ecomms returns exactly #185

merged 3 commits into from
Mar 18, 2024

Conversation

grmartin
Copy link
Member

  • Added settings for future formatting
  • Updating local settings to use the provisioned key name, even though it fails the standard format by having an underscore
  • Updating devstack to not use sqlite

@grmartin
fix: matching f-a-ecomms returns exactly
3d32b52 
- Added settings for future formatting
- Updating local settings to use the provisioned key name, even though it fails the standard format by having an underscore
- Updating devstack to not use sqlite
@grmartin grmartin mentioned this pull request Mar 15, 2024
Merged
@grmartin grmartin enabled auto-merge (squash) March 15, 2024 15:29
shafqatfarhan
shafqatfarhan approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@shafqatfarhan shafqatfarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Otherwise, looks good.

commerce_coordinator/settings/local.py Show resolved Hide resolved
commerce_coordinator/apps/commercetools/tests/test_data.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/data.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/catalog_info/utils.py Show resolved Hide resolved
@grmartin grmartin merged commit 2337494 into main Mar 18, 2024
3 checks passed
@grmartin grmartin deleted the gmartin/SONIC-375 branch March 18, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafqatfarhan shafqatfarhan shafqatfarhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grmartin @shafqatfarhan