Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comment for USE-JWT-COOKIE header #67

Merged
merged 1 commit into from
Aug 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
if ($request_method = 'OPTIONS') {
add_header 'Access-Control-Allow-Origin' $cors_origin;
add_header 'Access-Control-Allow-Methods' 'GET, POST, OPTIONS';
{# Leaving USE-JWT-COOKIE header in place, even though this could possibly be
cleaned up. We don't want to chance breaking ecommerce. Most backends
are using edx-drf-extensions>=10.2.0, and no longer use this header.
#}
add_header 'Access-Control-Allow-Headers' 'Authorization, USE-JWT-COOKIE';
{% if edx_django_service_allow_cors_credentials %}
add_header 'Access-Control-Allow-Credentials' true;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
if ($request_method = 'OPTIONS') {
add_header 'Access-Control-Allow-Origin' $cors_origin;
add_header 'Access-Control-Allow-Methods' 'GET, POST, OPTIONS';
{# Leaving USE-JWT-COOKIE header in place, even though this could possibly be
cleaned up. We don't want to chance breaking ecommerce. Most backends
are using edx-drf-extensions>=10.2.0, and no longer use this header.
#}
add_header 'Access-Control-Allow-Headers' 'Authorization, USE-JWT-COOKIE';
{% if edx_django_service_with_rendered_config_allow_cors_credentials %}
add_header 'Access-Control-Allow-Credentials' true;
Expand Down
Loading