Refactor of installation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Adds a download progress bar to get response during the call, which helps especially with slower connections to recognize timeouts etc. 2. Separates out the logic for download_knowledge_base(), which effectively allows downloads to be called from other parts of the library. 3. More expressive error messaging in case attributes passed to calls like python -m spacy_entity_linker are incorrect.
1. Automatically attempts to resolve errors that are likely caused by a missing KB; will download and then reconnect. 2. Also refactors some of the critical patterns, e.g., mutable default arguments, None-checking and use of internal attribute names (property).
Add test case to check whether empty root processing is correct.
setup.py is the default when installing from pip, instead requirements.txt is more for development requirements
|
Hi @dennlinger, |
|
I think that we can simply check if the database file exists ( Martino |
|
Thank you again @dennlinger for the very good contribution! Merging now! Martino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another thing that bothered me enough to open a PR is the lack of clear installation instructions (or rather, the lack of automating it).
__main__.pywith an incorrect argument now gives an appropriate error message, instead of just "quietly finishing."DatabaseConnection: Errors that are likely caused by the lack of a KB (and thus failing to connect to it) will trigger the download of the database, and then re-try the connection. This way, even without manually running the installation process, the download will be triggered on the first time users run the library. My only concern is thatsqlite3.OperationalErrors can be caused by a variety of other issues, which might make this a bad practice to download a KB each time...Thanks again for the great library, hope this helps give it a bit more usability!