Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript support #61

Merged
merged 2 commits into from
Mar 27, 2018
Merged

feat: add typescript support #61

merged 2 commits into from
Mar 27, 2018

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 26, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from popomore March 26, 2018 12:00
@atian25 atian25 mentioned this pull request Mar 26, 2018
4 tasks
@@ -18,6 +18,7 @@ module.exports = function(options) {
https: false,
key: '',
cert: '',
typescript: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个用例?看能否开启 egg-core

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加了

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files           7        7           
  Lines         408      408           
=======================================
  Hits          401      401           
  Misses          7        7
Impacted Files Coverage Δ
lib/utils/options.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdb17c...2e72cad. Read the comment docs.

@atian25 atian25 changed the title feat: add typescript docs feat: add typescript support Mar 26, 2018
@popomore popomore merged commit c71f693 into master Mar 27, 2018
@popomore popomore deleted the ts branch March 27, 2018 03:51
@atian25
Copy link
Member Author

atian25 commented Mar 27, 2018

发个版本

等 egg-bin 完后,合并你的 #60 一起发吧

@atian25
Copy link
Member Author

atian25 commented Mar 28, 2018

1.16.0

hyj1991 pushed a commit to hyj1991/egg-cluster that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants