feat: upgrade dependencies and devDependencies #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.75% // Head: 99.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage 99.75% 99.76%
=========================================
Files 19 19
Lines 1209 2935 +1726
Branches 212 546 +334
=========================================
+ Hits 1206 2928 +1722
- Misses 3 7 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
commented
Jan 1, 2023
| const assert = require('assert'); | ||
| const coffee = require('coffee'); | ||
|
|
||
| describe('test/jest.test.js', () => { |
There was a problem hiding this comment.
影响了 c8 生成覆盖率报告，看起来跟 mocha 会冲突，删除 jest 测试。不应该放这里。
atian25
pushed a commit
that referenced
this pull request
Jan 1, 2023
[skip ci] ## [5.0.0](v4.30.1...v5.0.0) (2023-01-01) ### ⚠ BREAKING CHANGES * drop Node.js < 14.17.0 support ### Features * upgrade dependencies and devDependencies ([#256](#256)) ([540f3fe](540f3fe))
fengmk2
commented
Jan 1, 2023
| }, | ||
| "dependencies": { | ||
| "@eggjs/router": "^2.0.0", | ||
| "@types/depd": "^1.1.32", |
There was a problem hiding this comment.
index.d.ts 有依赖 depd 和 koa，需要加回到 dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: drop Node.js < 14.17.0 support
Checklist
npm testpassesAffected core subsystem(s)
Description of change