Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use async function and support egg@2 #8

Merged
merged 3 commits into from
Nov 10, 2017
Merged

refactor: use async function and support egg@2 #8

merged 3 commits into from
Nov 10, 2017

Conversation

dead-horse
Copy link
Member

No description provided.

@popomore popomore mentioned this pull request Nov 10, 2017
29 tasks
package.json Outdated
"pedding": "^1.1.0",
"supertest": "^2.0.1"
"supertest": "^3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改为 app.httpRequest

empty: ctx.__(),
notexists_key: ctx.__('key not exists'),
empty_string: ctx.__(''),
novalue: ctx.__('key %s ok'),
// __ 别名 gettext 也可以使用
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English

@codecov-io
Copy link

codecov-io commented Nov 10, 2017

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          29     26    -3     
=====================================
- Hits           29     26    -3
Impacted Files Coverage Δ
app/middleware/i18n.js 100% <100%> (ø) ⬆️
app.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef32ac...9683a0e. Read the comment docs.

@dead-horse
Copy link
Member Author

fixed

@dead-horse dead-horse merged commit 80e591d into master Nov 10, 2017
@dead-horse dead-horse deleted the egg2 branch November 10, 2017 08:12
@dead-horse
Copy link
Member Author

2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants