fix: handleRequest method should return a promise (#3820)

eggjs · Jul 17, 2019 · 489f52b · 489f52b
1 parent 29a2f2f
commit 489f52b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/application.js b/lib/application.js
@@ -198,8 +198,8 @@ class Application extends EggApplication {
 
  handleRequest(ctx, fnMiddleware) {
  this.emit('request', ctx);
- super.handleRequest(ctx, fnMiddleware);
  onFinished(ctx.res, () => this.emit('response', ctx));
+ return super.handleRequest(ctx, fnMiddleware);
  }
 
  /**

diff --git a/test/app/extend/application.test.js b/test/app/extend/application.test.js
@@ -191,4 +191,22 @@ describe('test/app/extend/application.test.js', () => {
  );
  });
  });
+
+ describe('app.handleRequest(ctx, fnMiddleware)', () => {
+ let app;
+ before(() => {
+ app = utils.app('apps/demo');
+ return app.ready();
+ });
+ after(() => app.close());
+
+ it('should wait for middleware resolution', async () => {
+ const ctx = app.createAnonymousContext();
+ await app.handleRequest(ctx, async ctx => {
+ await sleep(100);
+ ctx.body = 'middleware resolution';
+ });
+ assert(ctx.body === 'middleware resolution');
+ });
+ });
 });