feat: support Keep-Alive Header (#2146)

node-modules/agentkeepalive#58
eggjs · Feb 28, 2018 · a739002 · a739002
1 parent c828436
commit a739002
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 0 deletions.
diff --git a/app/middleware/meta.js b/app/middleware/meta.js
@@ -12,5 +12,12 @@ module.exports = options => {
  await next();
  // total response time header
  ctx.set('x-readtime', Date.now() - ctx.starttime);
+
+ // try to support Keep-Alive Header
+ const server = ctx.app.server;
+ if (server && server.keepAliveTimeout && server.keepAliveTimeout >= 1000 && ctx.header.connection !== 'close') {
+ const timeout = parseInt(server.keepAliveTimeout / 1000);
+ ctx.set('keep-alive', `timeout=${timeout}`);
+ }
  };
 };
diff --git a/lib/application.js b/lib/application.js
@@ -48,6 +48,9 @@ class Application extends EggApplication {
  options.type = 'application';
  super(options);
 
+ // will auto set after 'server' event emit
+ this.server = null;
+
  try {
  this.loader.load();
  } catch (e) {
@@ -83,6 +86,9 @@ class Application extends EggApplication {
  }
 
  onServer(server) {
+ // expose app.server
+ this.server = server;
+
  /* istanbul ignore next */
  graceful({
  server: [ server ],

diff --git a/test/app/middleware/meta.test.js b/test/app/middleware/meta.test.js
@@ -42,4 +42,30 @@ describe('test/app/middleware/meta.test.js', () => {
  assert(content.includes('[meta] request started, host: '));
  });
  });
+
+ describe('cluster start', () => {
+ let app;
+ before(() => {
+ app = utils.cluster('apps/middlewares');
+ return app.ready();
+ });
+ after(() => app.close());
+
+ it('should ignore keep-alive header when request is not keep-alive', () => {
+ return app.httpRequest()
+ .get('/')
+ .expect('X-Readtime', /\d+/)
+ .expect(res => assert(!res.headers['keep-alive']))
+ .expect(200);
+ });
+
+ it('should return keep-alive header when request is keep-alive', () => {
+ return app.httpRequest()
+ .get('/')
+ .set('connection', 'keep-alive')
+ .expect('X-Readtime', /\d+/)
+ .expect('keep-alive', 'timeout=5')
+ .expect(200);
+ });
+ });
 });