Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo #1060

Merged
merged 2 commits into from
Jun 15, 2017
Merged

docs: typo #1060

merged 2 commits into from
Jun 15, 2017

Conversation

chenbin92
Copy link
Contributor

@chenbin92 chenbin92 commented Jun 15, 2017

Description of change

fix typo:

  • anonymouse -> anonymous
  • fix some typo in cluster-and-ipc.md

@@ -291,7 +291,7 @@ if (cluster.isMaster) {
- 在 agent 上调用该方法会发送给 agent 自己
- `agent.messenger.sendRandom(action, data)`:
- app 上没有该方法(现在 Egg 的实现是等同于 sentToAgent)
- agent 上回随机发送消息给一个 app 进程(由 master 来控制发送给谁)
- agent 上随机发送消息给一个 app 进程(由 master 来控制发送给谁)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是 agent 会随机发送

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@@ -291,7 +291,7 @@ if (cluster.isMaster) {
- 在 agent 上调用该方法会发送给 agent 自己
- `agent.messenger.sendRandom(action, data)`:
- app 上没有该方法(现在 Egg 的实现是等同于 sentToAgent)
- agent 上回随机发送消息给一个 app 进程(由 master 来控制发送给谁)
- agent 上会随机发送消息给一个 app 进程(由 master 来控制发送给谁)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该去掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新,去掉 语义是会好一些。

@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #1060 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          28       28           
  Lines         675      675           
=======================================
  Hits          668      668           
  Misses          7        7
Impacted Files Coverage Δ
lib/application.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d1b00...43d980b. Read the comment docs.

@dead-horse dead-horse merged commit bfb8df5 into eggjs:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants