Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set cluster options, include path, port, hostname #1231

Merged
merged 3 commits into from
Jul 27, 2017
Merged

feat: set cluster options, include path, port, hostname #1231

merged 3 commits into from
Jul 27, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented Jul 24, 2017 •
edited
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore
Copy link
Member Author

eggjs/egg-cluster#34

@popomore popomore changed the title feat: set cluster options, include path, port, hostname WIP: feat: set cluster options, include path, port, hostname Jul 24, 2017
@codecov
Copy link

codecov bot commented Jul 25, 2017 •
edited
Loading

Codecov Report

Merging #1231 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   99.71%   99.71%   +<.01%     
==========================================
  Files          29       29              
  Lines         710      711       +1     
==========================================
+ Hits          708      709       +1     
  Misses          2        2
Impacted Files Coverage Δ
config/config.default.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f93cf...34ecec0. Read the comment docs.

@popomore popomore changed the title WIP: feat: set cluster options, include path, port, hostname feat: set cluster options, include path, port, hostname Jul 25, 2017
@popomore
Copy link
Member Author

可以合了不

@atian25
Copy link
Member

atian25 commented Jul 26, 2017

没啥问题就 2 个都合了吧

@popomore popomore merged commit 3ef1de9 into master Jul 27, 2017
@popomore popomore deleted the cluster-options branch July 27, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atian25 atian25 atian25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popomore @atian25