docs: add egg-scripts to deployment #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2017
atian25
commented
Aug 2, 2017
docs/source/zh-cn/core/deployment.md
Outdated
|
|
||
| ### 自定义框架启动 | ||
| #### 手动创建启动文件 |
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 29 29
Lines 711 711
=======================================
Hits 709 709
Misses 2 2Continue to review full report at Codecov.
|
4 tasks
dead-horse
reviewed
Aug 3, 2017
docs/source/zh-cn/core/deployment.md
Outdated
|
|
||
| ### 启动配置项 | ||
| **注意：该方式不会读取应用目录下的 `index.js`。** |
There was a problem hiding this comment.
这一句没什么必要吧？可能很多人都不知道 Index.js 是什么..
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 29 29
Lines 711 711
=======================================
Hits 709 709
Misses 2 2Continue to review full report at Codecov.
|
|
这个还有问题不？ |
popomore
approved these changes
Aug 4, 2017
| ```json | ||
| { | ||
| "scripts": { | ||
| "start": "egg-scripts start --daemon", |
|
可以自己合并 |
|
那天看到之前 RFC 里面你建议默认前台的，而且 后面多是 docker 场景，就改了，那个 PR 最后有 cc 你的，可能没看到
发自我的 iPhone
… 在 2017年8月4日，21:55，Haoliang Gao ***@***.***> 写道：
@popomore approved this pull request.
In docs/source/zh-cn/core/deployment.md:
>
-egg.startCluster({
- baseDir: __dirname,
-});
+```json
+{
+ "scripts": {
+ "start": "egg-scripts start --daemon",
daemon 不是默认的么
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
popomore
pushed a commit
that referenced
this pull request
Aug 4, 2017
docs: add egg-scripts to deployment (#1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
eggjs/egg-scripts#1