docs(core/cookie-and-session): translate section Cookie #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 29 29
Lines 712 712
=======================================
Hits 709 709
Misses 3 3Continue to review full report at Codecov.
|
|
Thx for the translation. If you complete the translation, you can ping me to remove the label. |
|
@popomore , the translation of cookie-and-session is done. |
dead-horse
reviewed
Nov 13, 2017
|
|
||
| ```js | ||
| ctx.cookies.set(key, value, { | ||
| httpOnly: true, // 默认就是 true |
There was a problem hiding this comment.
translate the comments to English too
|
|
||
| Session is built on top of Cookie. | ||
| By default, the content of Session is stored in a Cookie field as encrypted string. | ||
| Every time client sends requests to server, is cookie is attached. |
|
@dead-horse , updated according to your comment. |
dead-horse
approved these changes
Nov 14, 2017
|
LGTM |
popomore
pushed a commit
that referenced
this pull request
Nov 14, 2017
docs(core/cookie-and-session): translate section Cookie (#1562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Work In Progress: Translate core/cookie-and-session