docs(plugin): add singleton support async create function #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 99.61% 99.64% +0.02%
==========================================
Files 29 29
Lines 783 840 +57
==========================================
+ Hits 780 837 +57
Misses 3 3
Continue to review full report at Codecov.
|
popomore
reviewed
Apr 14, 2018
docs/source/zh-cn/advanced/plugin.md
Outdated
| const rows = await client.query('select now() as currentTime;'); | ||
| const index = count++; | ||
| app.coreLogger.info(`[egg-mysql] instance[${index}] status OK, rds currentTime: ${rows[0].currentTime}`); | ||
| app.beforeStart(async function startMysql() { |
|
在看看，没问题合并我发个版本 |
popomore
approved these changes
Apr 15, 2018
popomore
pushed a commit
that referenced
this pull request
Apr 15, 2018
docs(plugin): add singleton support async create function (#2392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change