test: fix sitefile icon test #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
approved these changes
Aug 29, 2018
| @@ -14,16 +14,14 @@ describe('test/app/middleware/site_file.test.js', () => { | |||
| it('should GET /favicon.ico 200', () => { | |||
| return app.httpRequest() | |||
| .get('/favicon.ico') | |||
| .expect('Content-Type', 'image/x-icon') | |||
| // .expect(res => console.log(res.headers)) | |||
| .expect(res => assert(res.headers['content-type'].includes('icon'))) | |||
Codecov Report
@@ Coverage Diff @@
## master #2940 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 29 29
Lines 826 826
=======================================
Hits 824 824
Misses 2 2Continue to review full report at Codecov.
|
popomore
pushed a commit
that referenced
this pull request
Aug 29, 2018
test: fix sitefile icon test (#2940)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
jshttp/mime-db@0dc5b63#r30314927
这里带来的 breaking change，测试先修一下