Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: avoid DNS pollution on local env #3034

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 22, 2018

closes #3033

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 requested review from atian25 and a user September 22, 2018 06:40
@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

Merging #3034 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3034   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         829      829           
=======================================
  Hits          827      827           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bace243...c6b8a64. Read the comment docs.

@fengmk2 fengmk2 force-pushed the avoid-dns-pollution-on-local-env branch from bf0f90e to c6b8a64 Compare September 22, 2018 06:53
@ghost
Copy link

ghost commented Sep 22, 2018

@fengmk2,Your codes are technically right, however it seems it still depends on the remote server's DNS settings. Services such as 'unicom' 'telecom' will have different kinds of ways coping with the problem. Take 'unicome' as an example:
image

The result will be this:
image

So, you can ABSOLUTELY submit your codes, and I'll then make up a document to clearify this senario to cut off others' worry as well

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's no need to use 'test-local-changed', because we can directly use 'test-local' instead.

@fengmk2 fengmk2 merged commit b13d904 into master Sep 28, 2018
@fengmk2 fengmk2 deleted the avoid-dns-pollution-on-local-env branch September 28, 2018 13:35
popomore pushed a commit that referenced this pull request Sep 28, 2018
test: avoid DNS pollution on local env (#3034)

closes #3033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local unit test errors, but the remote one is OK with me
2 participants