feat: remove overrideMethod middleware #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse and @popomore to be potential reviewers. |
fengmk2
commented
Feb 7, 2017
| @@ -6,10 +6,10 @@ const MAX_AGE = 'public, max-age=2592000'; // 30 days | |||
| module.exports = options => { | |||
| return function* siteFile(next) { | |||
| if (this.method !== 'HEAD' && this.method !== 'GET') return yield next; | |||
|
|
|||
| if (!options.hasOwnProperty(this.path)) return yield next; | |||
| if (this.path[0] !== '/') return yield next; | |||
There was a problem hiding this comment.
加个字符串判断，就不担心 hasOwnProperty 被入注了
dead-horse
approved these changes
Feb 7, 2017
|
这个也是不兼容更新，内部要更新下。还有为啥去掉要写一下 |
|
@popomore 在内部 egg issue 回复了 |
fengmk2
force-pushed
the
remove-override-method
branch
2 times, most recently
from
b65e6ad
to
c1759af
Compare
It's not safe it enable by default in egg
fengmk2
force-pushed
the
remove-override-method
branch
from
c1759af
to
e7aa468
Compare
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage ? 98.08%
=========================================
Files ? 31
Lines ? 834
Branches ? 0
=========================================
Hits ? 818
Misses ? 16
Partials ? 0
Continue to review full report at Codecov.
|
|
@popomore 这个没问题就合并发个版本。 |
popomore
approved these changes
Feb 7, 2017
fengmk2
added a commit
that referenced
this pull request
Jun 19, 2017
only allow override method on POST request by default #324
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not safe it enable by default in egg
Checklist
npm testpassesAffected core subsystem(s)
Description of change