Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix some translations with some icons #3315

Merged
merged 1 commit into from Dec 17, 2018
Merged

doc: Fix some translations with some icons #3315

merged 1 commit into from Dec 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2018

  1. Fix some English translations for 'cookies-and-session.md' file.
  2. Union some icons for 'Right' and 'Wrong'.
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ghost ghost requested a review from atian25 December 16, 2018 08:36
1) Fix some English translations for 'cookies-and-session.md' file.
2) Union some icons for 'Right' and 'Wrong'.
@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #3315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3315   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc2037...7ce8162. Read the comment docs.

@ghost
Copy link
Author

ghost commented Dec 16, 2018

@atian25 :Plz have a check :)

@atian25 atian25 merged commit 0cb246e into eggjs:master Dec 17, 2018
popomore pushed a commit that referenced this pull request Dec 17, 2018
doc: Fix some translations with some icons (#3315)
@ghost ghost deleted the ChangIconAndTrans branch December 17, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants