fix: helper type #3483
Merged
fix: helper type #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3483 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 32 32
Lines 923 923
=======================================
Hits 920 920
Misses 3 3Continue to review full report at Codecov.
|
atian25
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
将 IHelper 改成继承 BaseContextClass ，在写 helper 的 extend 的时候，将 this type 指定为 IHelper 才能拿到
this.ctx，顺便将 BaseContextClass 里的 ctx、app 等改成 protected ，在外部使用的时候就不会出现这些干扰类型。