Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): optimize declaration of httpclient #3665

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Apr 30, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

补充并完善 httpclient 里支持的配置

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #3665 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3665    +/-   ##
=======================================
  Coverage     100%    100%            
=======================================
  Files          34      34            
  Lines         943    1147   +204     
=======================================
+ Hits          943    1147   +204
Impacted Files Coverage Δ
lib/egg.js 100% <0%> (ø) ⬆️
app/extend/request.js 100% <0%> (ø) ⬆️
app/extend/response.js 100% <0%> (ø) ⬆️
lib/core/httpclient.js 100% <0%> (ø) ⬆️
config/config.default.js 100% <0%> (ø) ⬆️
lib/loader/app_worker_loader.js 100% <0%> (ø) ⬆️
lib/core/base_context_logger.js 100% <0%> (ø) ⬆️
lib/core/dnscache_httpclient.js 100% <0%> (ø) ⬆️
lib/agent.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8dc7db...ea48a32. Read the comment docs.

Copy link
Member

@atian25 atian25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.22.2~~~

@atian25 atian25 requested a review from dead-horse April 30, 2019 02:59
@atian25 atian25 changed the title feat(typings): optimize declaration of httpclient fix(typings): optimize declaration of httpclient Apr 30, 2019
@atian25 atian25 merged commit 670ba34 into master Apr 30, 2019
@atian25 atian25 deleted the optimize-httpclient-declare branch April 30, 2019 03:47
popomore pushed a commit that referenced this pull request Apr 30, 2019
fix(typings): optimize declaration of httpclient (#3665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants