feat: warn if some confused configurations exist in config #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
approved these changes
Mar 24, 2017
fengmk2
reviewed
Mar 24, 2017
| */ | ||
| confusedConfigurations: { | ||
| bodyparser: 'bodyParser', | ||
| notFound: 'notfound', |
There was a problem hiding this comment.
不想做兼容，以后插件多了也没法全统一的，就这样吧。
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 633 638 +5
=====================================
+ Hits 633 638 +5
Continue to review full report at Codecov.
|
atian25
approved these changes
Mar 24, 2017
popomore
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
closes #620