feat: export context base classes on Application #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @atian25, @dead-horse and @popomore to be potential reviewers. |
fengmk2
commented
Apr 10, 2017
| @@ -96,7 +92,7 @@ const proto = module.exports = { | |||
| if (!appLogger) return null; | |||
|
|
|||
| // write to cache | |||
| cache[name] = new ContextLogger(this, appLogger); | |||
| cache[name] = new this.app.ContextLogger(this, appLogger); | |||
There was a problem hiding this comment.
方便上层应用和框架覆盖默认的这些 extends
dead-horse
approved these changes
Apr 10, 2017
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 637 640 +3
=====================================
+ Hits 637 640 +3
Continue to review full report at Codecov.
|
popomore
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change