Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add doc test #989

Merged
merged 7 commits into from
Jun 9, 2017
Merged

test: add doc test #989

merged 7 commits into from
Jun 9, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented Jun 2, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • improve jsdoc
  • fix broken links

- improve jsdoc
- fix broken links
@popomore popomore added the WIP label Jun 2, 2017
@popomore popomore requested a review from fengmk2 June 2, 2017 18:32
@popomore
Copy link
Member Author

popomore commented Jun 2, 2017

插件 README 有很多死链

@fengmk2
Copy link
Member

fengmk2 commented Jun 3, 2017

好吧

const path = require('path');

module.exports = () => {
return require('koa-static')(path.join(process.cwd(), 'run/doctools/public'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么不直接用 egg-static?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不支持 index

@popomore
Copy link
Member Author

popomore commented Jun 4, 2017

都得发个版本

@codecov
Copy link

codecov bot commented Jun 4, 2017

Codecov Report

Merging #989 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          28       28           
  Lines         675      675           
=======================================
  Hits          664      664           
  Misses         11       11
Impacted Files Coverage Δ
lib/core/messenger.js 76.31% <ø> (ø) ⬆️
lib/application.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6eb7b2...e68d068. Read the comment docs.

@popomore
Copy link
Member Author

popomore commented Jun 4, 2017

测试过了就可以了

@popomore
Copy link
Member Author

popomore commented Jun 8, 2017

这个可以合了么

@dead-horse dead-horse removed the WIP label Jun 8, 2017
@fengmk2
Copy link
Member

fengmk2 commented Jun 9, 2017

ci得重跑

@dead-horse dead-horse merged commit 057bc47 into master Jun 9, 2017
@dead-horse dead-horse deleted the improve-doc branch June 9, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants