Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cjs and esm both #4

Merged
merged 3 commits into from
Jun 15, 2024
Merged

feat: support cjs and esm both #4

merged 3 commits into from
Jun 15, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 15, 2024

BREAKING CHANGE: drop Node.js < 18.7.0 support

eggjs/egg#5257

Summary by CodeRabbit

  • New Features

    • Introduced automated GitHub Actions workflow for releasing code on the master branch.
    • Added a test suite to verify the functionality of the extend function.
  • Configuration

    • Extended ESLint configuration for TypeScript and node prefix rules.
    • Updated Node.js versions in GitHub Actions workflow to specific versions.
    • Updated tsconfig.json for stricter typing and modern ES2022 target.
  • Documentation

    • Updated README with TypeScript import syntax and licensing information.
    • Updated CHANGELOG for version 1.0.1 with noted fixes.
  • Miscellaneous

    • Updated .gitignore to exclude additional files and directories.
    • Added copyright notice for new contributors in LICENSE.
    • Significant updates to package.json including scripts, dependencies, and module configurations.

BREAKING CHANGE: drop Node.js < 18.7.0 support

eggjs/egg#5257
Copy link

socket-security bot commented Jun 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 91 kB fengmk2
npm/[email protected] environment, filesystem Transitive: eval +49 7.55 MB eslintbot
npm/[email protected] environment, filesystem Transitive: eval +89 4.8 MB ljharb

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

coderabbitai bot commented Jun 15, 2024

Warning

Rate limit exceeded

@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 47 minutes and 44 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between c882f10 and 4855c88.

Walkthrough

The repository update encompasses enhancements to TypeScript support, improved Node.js workflow configurations, and better documentation. Key changes include extending ESLint rules for TypeScript, refining Node.js versions in GitHub Actions workflows, adding a release workflow, and updating various configuration files. These adjustments aim to improve code quality, streamline release processes, and enhance project documentation and dependencies.

Changes

File Change Summary
.eslintrc Extended ESLint configuration for TypeScript and enforced node prefix.
.github/workflows/nodejs.yml Updated Node.js versions for GitHub Actions workflow.
.github/workflows/release.yml Introduced a new GitHub Actions workflow for code releases on the master branch.
.gitignore Added new patterns for ignored files and directories.
CHANGELOG.md Documented a fix addressing the copying of __proto__.
LICENSE Updated to include a new copyright notice.
README.md Transitioned from require to import statements in examples, and updated licensing and contributor information.
package.json Significant updates including changes to engines, publishConfig, description, scripts, devDependencies, files, type, tshy, exports, main, and types fields.
src/index.ts Refactored isPlainObject function, updated extend function with ES6 syntax, and exported extend as default.
test/index.test.ts Introduced a new test suite for verifying the extend function, covering various data types and scenarios.
tsconfig.json Extended from @eggjs/tsconfig and updated compiler options for strict typing, targeting ES2022, and using NodeNext for module resolution.

Poem

In the code's enchanted forest, new magic stirs,
TypeScript whispers softly, no silence deters.
Node versions align, workflows refined,
Releasing changes with peace of mind.
Git's secrets, extend's embrace,
A symphony of updates, humming with grace.
🌟🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 15, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@fengmk2 fengmk2 merged commit 378e295 into master Jun 15, 2024
9 checks passed
@fengmk2 fengmk2 deleted the next-major branch June 15, 2024 02:15
fengmk2 pushed a commit that referenced this pull request Jun 15, 2024
[skip ci]

## [4.0.0](v3.0.0...v4.0.0) (2024-06-15)

### ⚠ BREAKING CHANGES

* drop Node.js < 18.7.0 support

eggjs/egg#5257

### Features

* override array as primitive when deep merge ([#1](#1)) ([00c66c0](00c66c0))
* support cjs and esm both ([#4](#4)) ([378e295](378e295))

### Bug Fixes

* __proto__ copy ([#2](#2)) ([aa332a5](aa332a5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant