refactor: use async function and support koa@2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2 合并发个大版本吧 |
fengmk2
approved these changes
Nov 8, 2017
|
@dead-horse node >= 8.0.0 吧，都改掉 |
atian25
reviewed
Nov 8, 2017
| @@ -32,7 +32,7 @@ $ npm install koa-override --save | |||
| ## Usage | |||
|
|
|||
| ```js | |||
| const bodyParser = require('koa-body-parser') | |||
| const bodyParser = require('koa-bodyparser') | |||
There was a problem hiding this comment.
无所谓了，koa-bodyparser 是我们维护的，body-parser 估计是最早占了坑了
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 19 19
=====================================
Hits 19 19
Continue to review full report at Codecov.
|
|
done |
atian25
approved these changes
Nov 8, 2017
| return function* overrideMethod(next) { | ||
| const orginalMethod = this.request.method; | ||
| if (options.allowedMethods.indexOf(orginalMethod) === -1) return yield next; | ||
| return function overrideMethod(ctx, next) { |
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "index.js" | |||
| ], | |||
| "scripts": { | |||
| "test": "mocha -r co-mocha -R spec -t 5000 test/*.test.js", | |||
| "test": "mocha -R spec -t 5000 test/*.test.js", | |||
|
3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.