Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve css in print view #219

Merged
merged 6 commits into from
May 2, 2019
Merged

feat: improve css in print view #219

merged 6 commits into from
May 2, 2019

Conversation

kevgathuku
Copy link
Contributor

Fixes #215

Print view after applying changes in this PR:
image

@egoist
Copy link
Owner

egoist commented May 2, 2019

/cc @chanjsq

@egoist
Copy link
Owner

egoist commented May 2, 2019

Can you remove the left and right margin as well? seems we don't need that in print view

@kevgathuku
Copy link
Contributor Author

Sure. I'll fix that too @egoist

@kevgathuku
Copy link
Contributor Author

kevgathuku commented May 2, 2019

I've removed the margins. Here's how it looks now cc @egoist

image

@egoist
Copy link
Owner

egoist commented May 2, 2019

the margin in header in unnecessary too, maybe we don't even need the header? (@chanjsq)

@egoist
Copy link
Owner

egoist commented May 2, 2019

Maybe we should show header nav in print view.

@kevgathuku
Copy link
Contributor Author

the margin in header in unnecessary too, maybe we don't even need the header? (@chanjsq)

I've removed the left margin in the header and updated the image. Is this the header margin you meant?

@egoist egoist changed the title Hide Sidebar Toggle and Sidebar in print view feat: improve css in print view May 2, 2019
@egoist egoist merged commit 7071e1c into egoist:master May 2, 2019
@egoist
Copy link
Owner

egoist commented May 2, 2019

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label May 2, 2019
@kevgathuku
Copy link
Contributor Author

Nice. It's looking much better now 🚀
Thanks @egoist

@kevgathuku kevgathuku deleted the fix/print-view branch May 2, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Print Style
2 participants