Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#212 apply decoded uri for getting $route's path and hash #213

Merged
merged 1 commit into from
Apr 5, 2019
Merged

#212 apply decoded uri for getting $route's path and hash #213

merged 1 commit into from
Apr 5, 2019

Conversation

mcdoyaji
Copy link
Contributor

@mcdoyaji mcdoyaji commented Apr 5, 2019

For solving encoded uri not recognize by vue, I added decoded uri computed property inside home.vue

The reason I didn't use decodeURIComponent() function is vue router component guard function's to object has no encoded special character it's fullpath url.

Maybe there's a way passing component props through router beforeEach(), but I didn't because It's not simple.

Thanks and Regards

@egoist
Copy link
Owner

egoist commented Apr 5, 2019

I guess we only need to decode $route.hash

@mcdoyaji
Copy link
Contributor Author

mcdoyaji commented Apr 5, 2019

@egoist O.K All other's removed.

@egoist egoist merged commit 9d2826c into egoist:master Apr 5, 2019
@egoist
Copy link
Owner

egoist commented Apr 5, 2019

🎉 This PR is included in version 4.13.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants