camlCase dashes for css modules exports #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, we should update readme to tell users that dashes are always camelCased |
|
yeah, sure. I'm going to update that. |
|
just updated the doc |
|
LGTM |
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix an issue where exporting a selector which including dashes like
.foo-barwhen using css modules. Since now we are generatingexport const foo-bar = "....."and the dashes are illegal for javascript variables, the whole build phrase would fail.I'm just implementing
camelCase: 'dashes'option in webpack-style-loader. It's fairly enough for my use cases.