Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating API for parity with celestia-node v0.15.0 #340

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

distractedm1nd
Copy link
Contributor

Not ready for merge until node v0.15.0 is released, CI will also fail until then.

  • Adds TxConfig for blob and state modules
  • Removes GasPrice type and gas_prize_serializer
  • Removes SubmitTx endpoint from state module

rpc/src/blob.rs Outdated Show resolved Hide resolved
@zvolin zvolin requested a review from fl0rek August 21, 2024 18:19
@distractedm1nd
Copy link
Contributor Author

We're going to still need blob.Subscribe but that could also be a secondary PR

@zvolin
Copy link
Member

zvolin commented Aug 21, 2024

should be easy enough to add it right now

Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙌

ci/run-validator.sh Show resolved Hide resolved
rpc/tests/blob.rs Outdated Show resolved Hide resolved
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Maciej Zwoliński <[email protected]>
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@zvolin zvolin merged commit d9698d2 into eigerco:main Aug 22, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants