Improve initialization type frames #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
requested changes
Nov 21, 2023
checker/src/main/java/org/checkerframework/checker/initialization/InitializationVisitor.java
Outdated
Show resolved
Hide resolved
checker/src/main/java/org/checkerframework/checker/initialization/InitializationVisitor.java
Outdated
Show resolved
Hide resolved
checker/src/main/java/org/checkerframework/checker/initialization/InitializationVisitor.java
Show resolved
Hide resolved
...ain/java/org/checkerframework/checker/initialization/InitializationAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
| public @Nullable Object f; | ||
|
|
||
| public TypeFrames5(boolean dummy) { | ||
| @UnderInitialization(TypeFrames5.class) TypeFrames5 a = this; |
There was a problem hiding this comment.
I added this test to show that the type of this is correct even for non-final classes, which was previously also broken.
Can you think of another case to test?
wmdietl
reviewed
Nov 21, 2023
| for (VariableTree f : uninitializedFields) { | ||
| fieldsString.add(f.getName()); | ||
| } | ||
| // TODO: improve the error message by showing the uninitialized fields |
There was a problem hiding this comment.
@Ao-senXiong Can you please open an issue for this TODO and see how to improve this error message?
There was a problem hiding this comment.
@Ao-senXiong Can you please open an issue for this TODO and see how to improve this error message?
Ok, I will open up an issue
wmdietl
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610
An object of final class type
Ais now correctly considered@Initializedwhen all non-monotonic, non-null fields have been assigned. Previously, it was only considered@UnderInitialization(A.class).The problem only occurred if some fields of the class were either monotonic or nullable, which was not previously covered by test cases.