Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fwd ref into CF Manual #803

Closed
wants to merge 1 commit into from
Closed

Add fwd ref into CF Manual #803

wants to merge 1 commit into from

Conversation

alexvas
Copy link

@alexvas alexvas commented Jun 29, 2024

An intro of "Nullness Checker" section will reference "Generics and polymorphism" section to mention that defaults in the latter differs from defaults for a non-generic parameter, e.g. a Method argument.

That should help a new reader to catch the difference sooner. resolves: #795

An intro of "Nullness Checker" section will reference "Generics and polymorphism"
section to mention that defaults in the latter differs from defaults for
a non-generic parameter, e.g. a Method argument.

That should help a new reader to catch the difference sooner.
resolves: eisop#795
@wmdietl
Copy link
Member

wmdietl commented Jun 29, 2024

Thanks for the suggestion!
I've started #804 with an extra reference and different wording and a few other typo fixes.
What do you think of that wording?

For the future, please make sure that your git authorship is set correctly.
CI failed because you are missing from the contributors.tex file.
With your next PR, please add yourself to that file.

However, note that the CI system determined two names for your commits:

Akash Srivastava,
+Aleksandr Vasilev,
 Alex Liu,
+Alexander Vasiljev,
 Alvin Abdagic,
 Anant Jain,

So please fix that in your setup.

Thanks for the PR and please keep suggestions coming!

@wmdietl wmdietl closed this Jun 29, 2024
@alexvas
Copy link
Author

alexvas commented Jun 30, 2024

That wording is great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nullness] false positive for BasicMultimap
2 participants