Replies: 5 comments 17 replies
-
|
The idea is just to test the build script on two platforms, nix and ubuntu, to avoid any changes from breaking these two builds. I guess I am the only user for nix here, and most of the users will follow the build instructions for ubuntu. I'm fine removing the nix one. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I wasn't referring to nix; that's fine. I was just thinking it was odd that we build two different WASM bundles now - one for testing and a different one for binding. |
Beta Was this translation helpful? Give feedback.
-
|
Indeed, but I think it is fine: we don't want to include the testing stuff in the binding wasm, as we want a smaller binary. |
Beta Was this translation helpful? Give feedback.
-
|
@elalish if you comment assimp and gtest out, wasm builds just fine. but tests use meshio, so those fail 🤷 |
Beta Was this translation helpful? Give feedback.
-
|
@pca006132 if you remove these lines, shouldnt you be able to successfully run with the code I had here? |
Beta Was this translation helpful? Give feedback.
-
|
nix one was a separate issue that you have fixed. I am not an expert, but it kind of sounds strange that you say the test would still work when I disable test folders in CMakeLists 🤣 |
Beta Was this translation helpful? Give feedback.
-
|
Oh ok, I did not actually run it (I'm lying on my bed now) but I thought it should be fine. I will have a look at it tmr. |
Beta Was this translation helpful? Give feedback.
-
|
Wait, I'm still processing. Does @elalish mean that if you remove the entire build_wasm section, js demo will still be built elsewhere? |
Beta Was this translation helpful? Give feedback.
-
|
...is build_nix (js) it? |
Beta Was this translation helpful? Give feedback.
-
|
Honestly, I'm still trying to make sense of this myself. Let's move this discussion to the PR so we have some context. Also, @makc did you notice the big directory reorganization we just did? Your wasm stuff is now under |
Beta Was this translation helpful? Give feedback.
-
|
It works! Awesome team effort, all! https://elalish.github.io/manifold/bindings/wasm/examples/index.html |
Beta Was this translation helpful? Give feedback.
-
|
On my firefox client the page does not load. |
Beta Was this translation helpful? Give feedback.
-
|
Works fine on my computer (firefox 102.0.1). Can you open the network panel and see if it is caused by some scripts not being load or js/wasm error? |
Beta Was this translation helpful? Give feedback.
-
|
Somehow I'm getting a https://unpkg.com/three url and it's not loading. |
Beta Was this translation helpful? Give feedback.
-
|
it does indeed load two files from there:
Idk why would it not load for @fire but for me it loads fine in firefox. maybe it is network issue. |
Beta Was this translation helpful? Give feedback.
-
|
excited to have been pointed to this project! manifoldcad.org works but the simple demo being served here does not.
|
Beta Was this translation helpful? Give feedback.
-
|
Oh, good call, I bet I know exactly how I broke that yesterday. Will fix. |
Beta Was this translation helpful? Give feedback.
-
|
Fixed. |
Beta Was this translation helpful? Give feedback.
-
@makc @pca006132 I really want to serve some web examples on our Github pages so people can interact with our library live. I think the example with three.js is a perfect place to start. All we need is to make building that WASM library part of our
deploy.ymlscript and add relevant files todeploy.shto get them served.One question: do we still need ourbuild_wasmCI? It includes Assimp and our tests and everything - I wonder if this is really necessary any more? It seems a little odd to have two different WASM builds, but do we think it's important to independently test it? Curious what your thoughts are here.Beta Was this translation helpful? Give feedback.
All reactions